Add _ecVrfy and _ecSign #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add _ecVrfy and _ecSign to allow the user to customize the verification and signature functions (could be useful if the user wants to use BearSSLClient without ECC508) The functions can be customized through the constructor and are set to their current values as soon as the user calls setEccSlot Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
|
Memory usage change @436c232c451dc4ad7a1ce0ebd606cfbb4b21699b
|
aentinger
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Hi @ffontaine 👋 Thank you very much for your contribution. I've been hesitant so far to merge it since it would require changes in our ArduinoIoTCloud library. However, since ArduinoIoTCloud does no longer depend on ArduinoBearSSL this change is good to merge 👍
|
Thanks for merging this PR, I sent another small one to also allow the user to set its own certificate |
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add _ecVrfy and _ecSign to allow the user to customize the verification
and signature functions (could be useful if the user wants to use
BearSSLClient without ECC508)
The functions can be customized through the constructor and are set to
their current values as soon as the user calls setEccSlot
Signed-off-by: Fabrice Fontaine fabrice.fontaine@orange.com