-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure iContentLength doesn't wrap around due to malformed packets #176
Conversation
Memory usage change @ 1a3fb98
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we assume that the incoming value is already checked for not being negative? I think this code might make the new value positive for some negative incoming values. I don't know if this matters, since I don't know if there are checks for negative values somewhere later, or if negative incoming values are even possible, or can break things at a later stage.
@rhpco @rhaidiz can you take a look?