-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove internal global functions and unwanted public functions #387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pennam
changed the title
Remove global functions
Remove internal global functions and unwanted public functions
Oct 10, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
==========================================
- Coverage 95.00% 94.84% -0.16%
==========================================
Files 27 27
Lines 1220 1223 +3
==========================================
+ Hits 1159 1160 +1
- Misses 61 63 +2
☔ View full report in Codecov by Sentry. |
Memory usage change @ c15c145
Click for full report table
Click for full report CSV
|
superseded by #440 |
per1234
added
conclusion: duplicate
Has already been submitted
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
conclusion: duplicate
Has already been submitted
topic: code
Related to content of the project itself
type: enhancement
Proposed improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
To handle
timezone
andthing-id
changes from the cloud UI the following global functions were added:ArduinoIoTCloud/src/ArduinoIoTCloudTCP.cpp
Line 63 in 6a9acc2
ArduinoIoTCloud/src/ArduinoIoTCloudTCP.cpp
Line 68 in 6a9acc2
Together with other public functions that should be only used for internal purposes:
ArduinoIoTCloud/src/ArduinoIoTCloud.h
Line 99 in 6a9acc2
ArduinoIoTCloud/src/ArduinoIoTCloud.h
Line 100 in 6a9acc2
ArduinoIoTCloud/src/ArduinoIoTCloud.h
Line 101 in 6a9acc2
ArduinoIoTCloud/src/ArduinoIoTCloud.h
Line 103 in 6a9acc2
Changes
This PR removes the global functions and unwanted public methods to handle
thing-id
andtimezone
changes.Other Info
Regarding commit 1917639 I'm not sure if this behaviour was intended or not, but I've found out that for
read-only
property thecloud_value
is never updated. This change allows to update the cloud_value of aread-only
property allowing also the possibility to manually change the local value calling thefromCloudTiLocal()
function. This is a bit hacky and not 100% correct. To fix this we should add a local update policy [manual
/auto
] to add the possibility to handle the propertylocal_value
update manually.