Add NTPServerSync before getNetworkTime #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pennam
requested review from
cristidragomir97 and
sebromero
and removed request for
sebromero
|
Memory usage change @ cf8c0e3
Click for full report table
Click for full report CSV |
sebromero
requested changes
Jun 3, 2024
Contributor
sebromero
left a comment
sebromero
left a comment
There was a problem hiding this comment.
Let's use the return code of NTPServerSync. -1 indicates an error. Maybe we can return UNIX time Time(1970,1,1,0,0,0,0) in that case.
|
Memory usage change @ 5f9ad4c
Click for full report table
Click for full report CSV |
sebromero
reviewed
Jun 3, 2024
src/ArduinoCellular.cpp
Outdated
| int second = 0; | ||
| float tz; | ||
| modem.getNetworkTime(&year, &month, &day, &hour, &minute, &second, &tz); | ||
| if (modem.NTPServerSync()) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (modem.NTPServerSync()) { | |
| if (modem.NTPServerSync() == 0) { |
I think a return code of 0 indicates success. @cristidragomir97 can you double check?
Contributor
Author
There was a problem hiding this comment.
Oh yes, i was for sure wrong. I've changed it checking if != -1 to be on the safe side 🙂
Contributor
There was a problem hiding this comment.
@pennam I think that -1 is the generic error code while there are other +CNTP: result codes that indicate an error. I'd check for == 0.
|
Memory usage change @ b53f899
Click for full report table
Click for full report CSV |
|
Memory usage change @ 94aeac0
Click for full report table
Click for full report CSV |
per1234
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
getNetworkTimewithoutNTPServerSyncreturns some weird time values in the past1388591169 -> Wed Jan 01 2014 15:46:09 GMT+0000Adding
NTPServerSynccall solves this issue