AE-591: "turnOffEthernet" relocation to be executed before turning rails off. #20
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be executed just before we set the peripheral rails to off. This way we make sure the Eth Phy is still powered when sending the command to turn it off, and afterwards we can also turn all rails off as well.
sebromero
force-pushed
the
AE-591_3v3_rail_turns_back_on_when_entering_standby_mode
branch
from
5ce6016 to
fbde60b
Compare
per1234
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved call to "turnOffEthernet" in "setAllPeripheralsPower" to be executed just before we set the peripheral rails to off. This way we make sure the Eth Phy is still powered when sending the command to turn it off, and afterwards we can also turn all rails off as well.