Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support SSL module certificates management #111

Merged
merged 4 commits into from
Jun 17, 2020
Merged

support SSL module certificates management #111

merged 4 commits into from
Jun 17, 2020

Conversation

Rocketct
Copy link
Contributor

already tested

cc:/ @facchinm can you do a fast review? it works as expected

@Rocketct Rocketct requested a review from facchinm June 17, 2020 13:56
@manchoz
Copy link
Contributor

manchoz commented Jun 17, 2020

Hi @Rocketct,
in order to have the API using standard names for TLS jargon, I would suggest renaming a few methods:

  • setServerName to useTrustedRoot
  • setPrivateCertificate to setSignedCertificate
  • setClientName to useSignedCertificate
  • setClientKey to usePrivateKey

facchinm
facchinm requested changes Jun 17, 2020
View reviewed changes
src/GSMSSLClient.cpp Outdated Show resolved Hide resolved
@Rocketct
Copy link
Contributor Author

please guys double check again

@Rocketct Rocketct requested a review from facchinm June 17, 2020 14:47
@manchoz
Copy link
Contributor

manchoz commented Jun 17, 2020

LGTM

@Rocketct Rocketct merged commit 031723d into arduino-libraries:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm facchinm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rocketct @manchoz @facchinm