Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in SMS::peek(), and allow for multiple CIDs in GPRS::ready() #100

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

Patrick-McGuire
Copy link
Contributor

In NB_SMS::peek() the incoming SMS message pointer would be incremented, clipping off the first letter of the incoming message. I found and fixed this issue.

In GPRS::ready() was not designed to handle multiple CIDs when connecting to GPRS. Firmware updates to the SARA-R4 allow support for multiple CIDs, and this library would hang when connecting if multiple CIDs were reported from AT+CGACT. I fixed this issue.

@CLAassistant
Copy link

CLAassistant commented Jun 1, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Memory usage change @ f0e5bfc

Board flash % RAM for global variables %
arduino:samd:mkrnb1500 🔺 0 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/GPRSUdpNtpClient
flash
% examples/GPRSUdpNtpClient
RAM for global variables
% examples/NBSSLWebClient
flash
% examples/NBSSLWebClient
RAM for global variables
% examples/NBWebClient
flash
% examples/NBWebClient
RAM for global variables
% examples/ReceiveSMS
flash
% examples/ReceiveSMS
RAM for global variables
% examples/SendSMS
flash
% examples/SendSMS
RAM for global variables
% examples/Tools/ChooseRadioAccessTechnology
flash
% examples/Tools/ChooseRadioAccessTechnology
RAM for global variables
% examples/Tools/NBScanNetworks
flash
% examples/Tools/NBScanNetworks
RAM for global variables
% examples/Tools/PinManagement
flash
% examples/Tools/PinManagement
RAM for global variables
% examples/Tools/SerialSARAPassthrough
flash
% examples/Tools/SerialSARAPassthrough
RAM for global variables
% examples/Tools/TestGPRS
flash
% examples/Tools/TestGPRS
RAM for global variables
% examples/Tools/TestModem
flash
% examples/Tools/TestModem
RAM for global variables
%
arduino:samd:mkrnb1500 0 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/GPRSUdpNtpClient<br>flash,%,examples/GPRSUdpNtpClient<br>RAM for global variables,%,examples/NBSSLWebClient<br>flash,%,examples/NBSSLWebClient<br>RAM for global variables,%,examples/NBWebClient<br>flash,%,examples/NBWebClient<br>RAM for global variables,%,examples/ReceiveSMS<br>flash,%,examples/ReceiveSMS<br>RAM for global variables,%,examples/SendSMS<br>flash,%,examples/SendSMS<br>RAM for global variables,%,examples/Tools/ChooseRadioAccessTechnology<br>flash,%,examples/Tools/ChooseRadioAccessTechnology<br>RAM for global variables,%,examples/Tools/NBScanNetworks<br>flash,%,examples/Tools/NBScanNetworks<br>RAM for global variables,%,examples/Tools/PinManagement<br>flash,%,examples/Tools/PinManagement<br>RAM for global variables,%,examples/Tools/SerialSARAPassthrough<br>flash,%,examples/Tools/SerialSARAPassthrough<br>RAM for global variables,%,examples/Tools/TestGPRS<br>flash,%,examples/Tools/TestGPRS<br>RAM for global variables,%,examples/Tools/TestModem<br>flash,%,examples/Tools/TestModem<br>RAM for global variables,%
arduino:samd:mkrnb1500,0,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jun 2, 2022
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants