Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GSM and UCS2 sms charsets #34

Merged
merged 28 commits into from
Dec 4, 2020

Conversation

janakelarsson
Copy link
Contributor

Enable GSM sms charset

@janakelarsson janakelarsson changed the title Smscharset Enable GSM sms charset Jan 18, 2020
@janakelarsson janakelarsson changed the title Enable GSM sms charset Enable GSM and UCS2 sms charsets Jun 30, 2020
@janakelarsson
Copy link
Contributor Author

Build failed unrelated to the code. Close and reopen to trigger new build.

@janakelarsson
Copy link
Contributor Author

Something has changed at githubusercontent. Rerun test later.

@janakelarsson
Copy link
Contributor Author

Trying again

@aentinger
Copy link
Contributor

Hi @janakelarsson 👋 sorry for the long delay. Can you rebase this on the current master thereby solving the merge conflicts (which came about by me merging your other outstandings PRs). If everything still works afterwards we can merge that one in. After that @CCorrado we can move ahead and make a new release.

@CCorrado
Copy link
Contributor

CCorrado commented Dec 2, 2020

Thank you @aentinger! Much appreciated to @janakelarsson as well!

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you @janakelarsson 🚀

@aentinger aentinger merged commit a57a40c into arduino-libraries:master Dec 4, 2020
@janakelarsson janakelarsson deleted the smscharset branch December 4, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants