Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No SMS deadlock #52

Merged
merged 5 commits into from
Dec 2, 2020
Merged

Conversation

janakelarsson
Copy link
Contributor

Add timeout for endSMS() and available(), corresponding to the data sheet timeout. Without this, if the modem hangs or provides an unexpected answer, the library may hang forever.

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you @janakelarsson 🚀

@aentinger aentinger merged commit 86b4d24 into arduino-libraries:master Dec 2, 2020
@janakelarsson janakelarsson deleted the nosmsdeadlock branch December 4, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants