-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add File System #53
Add File System #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thank you very much @giulcioffi 🚀 I had only one small question. There's one other thing though: Could you please add at least one small example showcasing how to use this file utility function from a user perspective (e.g. store a small text file containing a string and read it back).
src/Modem.cpp
Outdated
@@ -54,10 +54,11 @@ int ModemClass::begin(bool restart) | |||
if (!autosense()) { | |||
return 0; | |||
} | |||
|
|||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good morning @giulcioffi ☕ I've been wondering if we can't fully delete the code if it's commented out already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FileUtilsJsonFile.ino as a starting point. (There are other FileUtils examples in the Tools
directory).
src/NBFileUtils.cpp
Outdated
int num = listFiles(files); | ||
|
||
Serial1.print("Im in existFile. Num of files after listFiles: "); | ||
Serial1.println(num); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these debugging leftovers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, the print on Serial1 are debugging leftovers. I'm going to delete them.
This File System is the one already supported by MKRGSM 1400. Only few functions have been modified/added to use it for MKRNB 1500 and its second stage Bootloader (SBU).