Add a choice of what messages to preserve to clear() #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ b67ae60
Click for full report table
Click for full report CSV |
aentinger
requested changes
Dec 9, 2020
|
The numerical constants are fixed in the modem code, listed in the manual. I'll see what I can do. |
|
I know that they are fixed in the modem firmware 😉, I mean to provide meaningful names for the user of this library. E.g. typedef enum SmsClearMode
{
/* ... */
xyz = 2,
PreserveUnread = 3,
PreserveNoMessage = 4,
};
void clear(SmsClearMode const mode = xyz); |
|
I used a #define, didn't see the enum until now, hope that is ok |
|
Memory usage change @ f221527
Click for full report table
Click for full report CSV |
aentinger
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.