Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected wrong order in subtraction for UDP available #67

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

baender
Copy link
Contributor

@baender baender commented Dec 7, 2020

This is the pull request to issue #66
The calculation of available bytes in UDP.available() seems to be reverted. Changing the order in the subtraction leads to the correct number of bytes available.

@github-actions
Copy link

github-actions bot commented Dec 7, 2020

Memory usage change @ f7fcf36

Board flash % RAM for global variables %
arduino:samd:mkrnb1500 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/GPRSUdpNtpClient
flash
% examples/GPRSUdpNtpClient
RAM for global variables
% examples/NBSSLWebClient
flash
% examples/NBSSLWebClient
RAM for global variables
% examples/NBWebClient
flash
% examples/NBWebClient
RAM for global variables
% examples/ReceiveSMS
flash
% examples/ReceiveSMS
RAM for global variables
% examples/SendSMS
flash
% examples/SendSMS
RAM for global variables
% examples/Tools/ChooseRadioAccessTechnology
flash
% examples/Tools/ChooseRadioAccessTechnology
RAM for global variables
% examples/Tools/NBScanNetworks
flash
% examples/Tools/NBScanNetworks
RAM for global variables
% examples/Tools/PinManagement
flash
% examples/Tools/PinManagement
RAM for global variables
% examples/Tools/SerialSARAPassthrough
flash
% examples/Tools/SerialSARAPassthrough
RAM for global variables
% examples/Tools/TestGPRS
flash
% examples/Tools/TestGPRS
RAM for global variables
% examples/Tools/TestModem
flash
% examples/Tools/TestModem
RAM for global variables
%
arduino:samd:mkrnb1500 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/GPRSUdpNtpClient<br>flash,%,examples/GPRSUdpNtpClient<br>RAM for global variables,%,examples/NBSSLWebClient<br>flash,%,examples/NBSSLWebClient<br>RAM for global variables,%,examples/NBWebClient<br>flash,%,examples/NBWebClient<br>RAM for global variables,%,examples/ReceiveSMS<br>flash,%,examples/ReceiveSMS<br>RAM for global variables,%,examples/SendSMS<br>flash,%,examples/SendSMS<br>RAM for global variables,%,examples/Tools/ChooseRadioAccessTechnology<br>flash,%,examples/Tools/ChooseRadioAccessTechnology<br>RAM for global variables,%,examples/Tools/NBScanNetworks<br>flash,%,examples/Tools/NBScanNetworks<br>RAM for global variables,%,examples/Tools/PinManagement<br>flash,%,examples/Tools/PinManagement<br>RAM for global variables,%,examples/Tools/SerialSARAPassthrough<br>flash,%,examples/Tools/SerialSARAPassthrough<br>RAM for global variables,%,examples/Tools/TestGPRS<br>flash,%,examples/Tools/TestGPRS<br>RAM for global variables,%,examples/Tools/TestModem<br>flash,%,examples/Tools/TestModem<br>RAM for global variables,%
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch 👍 Thank you very much @baender 🚀

@aentinger
Copy link
Contributor

This fixes #66.

@aentinger aentinger merged commit cff06db into arduino-libraries:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants