Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardReset method to match the datasheet #70

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

CCorrado
Copy link
Contributor

After reviewing the code for the MKRNB library, I noticed the hardReset method is still incorrect when compared to the SARA-R410M-02B datasheet.

image

Ref: https://www.u-blox.com/sites/default/files/SARA-R4_DataSheet_%28UBX-16024152%29.pdf

@github-actions
Copy link

Memory usage change @ 47c66f2

Board flash % RAM for global variables %
arduino:samd:mkrnb1500 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/GPRSUdpNtpClient
flash
% examples/GPRSUdpNtpClient
RAM for global variables
% examples/NBSSLWebClient
flash
% examples/NBSSLWebClient
RAM for global variables
% examples/NBWebClient
flash
% examples/NBWebClient
RAM for global variables
% examples/ReceiveSMS
flash
% examples/ReceiveSMS
RAM for global variables
% examples/SendSMS
flash
% examples/SendSMS
RAM for global variables
% examples/Tools/ChooseRadioAccessTechnology
flash
% examples/Tools/ChooseRadioAccessTechnology
RAM for global variables
% examples/Tools/NBScanNetworks
flash
% examples/Tools/NBScanNetworks
RAM for global variables
% examples/Tools/PinManagement
flash
% examples/Tools/PinManagement
RAM for global variables
% examples/Tools/SerialSARAPassthrough
flash
% examples/Tools/SerialSARAPassthrough
RAM for global variables
% examples/Tools/TestGPRS
flash
% examples/Tools/TestGPRS
RAM for global variables
% examples/Tools/TestModem
flash
% examples/Tools/TestModem
RAM for global variables
%
arduino:samd:mkrnb1500 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/GPRSUdpNtpClient<br>flash,%,examples/GPRSUdpNtpClient<br>RAM for global variables,%,examples/NBSSLWebClient<br>flash,%,examples/NBSSLWebClient<br>RAM for global variables,%,examples/NBWebClient<br>flash,%,examples/NBWebClient<br>RAM for global variables,%,examples/ReceiveSMS<br>flash,%,examples/ReceiveSMS<br>RAM for global variables,%,examples/SendSMS<br>flash,%,examples/SendSMS<br>RAM for global variables,%,examples/Tools/ChooseRadioAccessTechnology<br>flash,%,examples/Tools/ChooseRadioAccessTechnology<br>RAM for global variables,%,examples/Tools/NBScanNetworks<br>flash,%,examples/Tools/NBScanNetworks<br>RAM for global variables,%,examples/Tools/PinManagement<br>flash,%,examples/Tools/PinManagement<br>RAM for global variables,%,examples/Tools/SerialSARAPassthrough<br>flash,%,examples/Tools/SerialSARAPassthrough<br>RAM for global variables,%,examples/Tools/TestGPRS<br>flash,%,examples/Tools/TestGPRS<br>RAM for global variables,%,examples/Tools/TestModem<br>flash,%,examples/Tools/TestModem<br>RAM for global variables,%
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@CCorrado
Copy link
Contributor Author

@janakelarsson @aentinger am I misinterpreting the datasheet? It says minimum 10s for low pulse to reset the modem using RESETN. 1 second, in my testing on my MKR NB 1500, does nothing to reset the modem.

@janakelarsson
Copy link
Contributor

janakelarsson commented Dec 19, 2020

Thanks, I must have missed that somehow. In my case, 1 s was sufficient to reset the modem.

@CCorrado
Copy link
Contributor Author

@aentinger any thoughts around this one?

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 10 seconds strike me as containing a high margin for safety but since the data seem to require such a long delay I'm good with this change.

@aentinger aentinger merged commit 482e928 into arduino-libraries:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants