This repository was archived by the owner on Oct 4, 2021. It is now read-only.
Switch to LSM9D1 on new carrier #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -248,27 +255,35 @@ int analogReadAverage(int pin, int numberOfSamples) { | |||
| } | |||
|
|
|||
| void updateSubscribedIMUCharacteristics() { | |||
|
|
|||
| imu.read(); | |||
There was a problem hiding this comment.
@facchinm is this throttled to wait for a new sample?
There was a problem hiding this comment.
Nope, should we throttle it?
There was a problem hiding this comment.
Yes!
The MKRIMU lib call's to available() return the data at 10 Hz (from what I remember). This has two purposes, limited BLE bandwidth and reduces the load on the mobile phone app.
There was a problem hiding this comment.
It makes sense; @agdl can you take a look at this maybe?
There was a problem hiding this comment.
Look at last commit and let me know if this is ok!
There was a problem hiding this comment.
I think we can do better and look at the datasheet of the part ... and see if the Adafruit lib is using it properly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.