-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Cancel button for verify/upload #5928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't see a "CANCEL" button in my IDE - so how does it work? |
The main problem tackled by #3771 is the fact that most programmers, if something goes wrong, lock the serial port indefinitely. |
Clicking the button again to cancel isn't intuitive, I never would have thought to do that and I've been a professional developer for more than 30 years. Switching the button image (which is what I think you're saying when you say change the svg, but that's not clear) would work, but then you'd have to change both buttons, and why do all that work when you can just add a Cancel button when Verify or Upload are in progress. Do you really think you need to speak with a UX expert to figure this out? It's a simple problem and an simple, commonly implemented solution. I can list 10 reasons why it's needed:
I could go on and on and on. @shiftleftplusone there isn't a button, I'm suggesting that one be added (by someone other than me as I don't know the code well enough to add it myself). |
The cancel button was suggested in the past and rejected with UX motivations. On the same topic, the Serial Plotter button near the Serial terminal one was rejected too with the same UX motivations. Create implements a modal cancel button for both compile and upload (it replaces the upload button only if this one was pressed) so I believe it's the way to go if we want to implement this feature |
I already tried that "click upload a 2nd time" on my Due without knowing that that was a trick which actually was supposed to work, nonetheless, it didn't - when it once hung up, it didn't help to click it a 2nd time. |
I seem to recall that the upload/compilation process isn't actually properly tracked in the code right now. I think when you click the upload or verify again, it will just run two processes concurrently, which will almost certainly not behave the way you want to. I think the code that runs the verify/upload processes would benefit from a big cleanup/refactor (there is a lot of legacy code still from processing there that serves no purpose anymore), keeping in mind the need to more properly abort a running process. A related issue with aborting avrdude is #3569. |
Aborting by restarting isn't aborting, it's restarting! :P |
Yes, please fix this. |
At this point I think we'd all be happy if they just stopped trying to batter an open and locked port 9 more times after a failed sync. Just stop if sync fails and close the port. That would save loads of time and let us retry more quickly. |
Now tracked at arduino/arduino-ide#1199 |
The IDE should display a cancel button (a small X button near the progress bar for example) that allows users to cancel verify/upload. I find myself accidentally clicking the upload button when I want to click verify (I know, I'm tired) and I have to wait for the complete build and a failed deploy before I can get back to work.
The text was updated successfully, but these errors were encountered: