1.5.x enhancements: serial monitor autostart and editor window size autosave

[MartyMacGyver]

I've created two small enhancements targeting 1.5.x:

• Add preference serial.autostart to start serial monitor after a successful upload (Martin Falatic)
• Save editor.window.{width|height}.default values based on last editor window closed (Martin Falatic)

[damellis]

Some thoughts on automatically opening the serial monitor after an upload:

I never really liked this behavior, which is why I didn't implement it (http://code.google.com/p/arduino/issues/detail?id=311). Cristian, however, is in charge of the software now and he might have a different opinion. If something like this is added, though, I don't think it should be through a hidden option in the preferences file, because most people won't find it or use it.

Instead, my suggestion would be for the serial monitor to automatically re-open upon successful completion of an upload if it was already open when the upload was initiated (and was closed automatically by the software). This should probably be tested with the Leonardo and Due to make sure it doesn't cause any problems. If a user doesn't want the serial monitor to re-open automatically, they could just close it manually before doing an upload. I don't think you'd need any preferences (hidden or visible).

[MartyMacGyver]

Judging by the comments, there and elsewhere, users who have an opinion at all on this favor having an auto-on feature for serial monitoring, and the few who dislike it could simply not use the feature to begin with. That's why I made it an option.

As for the fact that it's a "hidden" option, a fair number of options exist for which there is nothing in the preference dialog (e.g., the editor size). If that's the mechanism for hiding more obscure options then I feel it's sufficient to make the functionality available, whereas some things, like editor size, should be so basic that they needn't be fixed options at all but automatic ones. Personally I prefer a robust preferences dialog, not a few checkboxes and a link to manually edit the .ini file... ultimately the preferences dialog should be the ONLY way people change features. Editing .ini files is not a robust design, but just because the preferences dialog isn't up to snuff doesn't mean we shouldn't add functionality that is eventually exposed in a preferences dialog enhancement (overhaul).

In regard to your second point, auto-opening the serial monitor only if you had it open to begin with, I favor a blend of the two eventually: have a preference for auto-re-open as well as one for auto-open in general. However, my take on this is that the people who want this option won't be toggling it very often, and would at least want the ability to have it "always on" if so desired. That, and less code is involved... better to get the base feature in place and then enhance it (add more granularity to the options like you've suggested as well as preference dialog entries) than to leave it entirely out.

[ffissore]

Hi @MartyMacGyver and sorry for the late reply. Autostarting serial monitor was an old feature request we never liked. Today we merged a similar feature, proposed in #2180 and later in #2742. However with your PR you're also proposing a way to save window size: would you like to review this PR (or make a brand new one) in order to include such feature only?

[ffissore]

Closing. On second though, it's better to start from a brand new PR rather than fixing this. Thanks!