Let EthernetServer::write return the number of bytes written to any client #1699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient Before, it would return the sum of the number of bytes written to all clients, which makes it hard for a caller to find out the length of an object printed (e.g., for alignment purposes). On the flipside, the return value is now slightly less useful to detect connection errors, but if really needed, something different should probably be implemented anyway.
|
Btw, this pullreq is for 1.5, but the same patch applies unmodified to 1.0. I'm happy to supply another pullreq for that if that helps. |
|
Any chance this could be merged? Or is there anything blocking this? |
matthijskooijman
added
Type: Bug
Version: 1.5.x
Library: Ethernet
|
This issue was moved to arduino-libraries/Ethernet#35 |
|
Sorry closed by mistake |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, it would return the sum of the number of bytes written to all
clients, which makes it hard for a caller to find out the length of an
object printed (e.g., for alignment purposes). On the flipside, the
return value is now slightly less useful to detect connection errors,
but if really needed, something different should probably be implemented
anyway.
This change was discussed here:
http://comments.gmane.org/gmane.comp.hardware.arduino.devel/1928
http://forum.arduino.cc/index.php?topic=185835.0