Skip to content

HardwareSerial improvements #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

HardwareSerial improvements #1711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3a9c989
Remove duplicate code from HardwareSerial::begin() methods.
matthijskooijman Apr 19, 2013
43c65f4
Remove unused variable
matthijskooijman Apr 19, 2013
a2fa47b
Simplify HardwareSerial::begin()
matthijskooijman Apr 19, 2013
193bb9a
Define a _NOP() macro
matthijskooijman Dec 1, 2013
b99521d
Use constants for register bit positions in HardwareSerial
matthijskooijman Apr 18, 2013
91a405c
Move interrupt handlers into HardwareSerial class
matthijskooijman Apr 18, 2013
da984c9
Use bit_is_clear in HardwareSerial::flush()
matthijskooijman Apr 18, 2013
59c6467
Improve HardwareSerial::flush()
matthijskooijman Apr 18, 2013
b7e9bb4
Fix HardwareSerial::flush() when interrupts are kept disabled for a w…
matthijskooijman Apr 19, 2013
eb86af7
Fix lockup when writing to HardwareSerial with interrupts disabled
matthijskooijman Apr 18, 2013
7c337d2
Disable the UDRE interrupt sooner in HardwareSerial
matthijskooijman Apr 18, 2013
a0d0bfb
Centrally decide which hardware UARTS are available
matthijskooijman Dec 1, 2013
aa584bc
Put each HardwareSerial instance in its own .cpp file
matthijskooijman Dec 3, 2013
e1599f3
Make all access to the HardwareSerial ringbuffers atomic
matthijskooijman Apr 18, 2013
6e03352
In HardwareSerial::write, bypass the queue when it's empty
matthijskooijman Dec 18, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions hardware/arduino/avr/cores/arduino/Arduino.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ void yield(void);
#define bitClear(value, bit) ((value) &= ~(1UL << (bit)))
#define bitWrite(value, bit, bitvalue) (bitvalue ? bitSet(value, bit) : bitClear(value, bit))

// avr-libc defines _NOP() since 1.6.2
#ifndef _NOP
#define _NOP() do { __asm__ volatile ("nop"); } while (0)
#endif

typedef unsigned int word;

Expand Down Expand Up @@ -195,6 +199,10 @@ extern const uint8_t PROGMEM digital_pin_to_timer_PGM[];
#include "WCharacter.h"
#include "WString.h"
#include "HardwareSerial.h"
#include "USBAPI.h"
#if defined(HAVE_HWSERIAL0) && defined(HAVE_CDCSERIAL)
#error "Targets with both UART0 and CDC serial not supported"
#endif

uint16_t makeWord(uint16_t w);
uint16_t makeWord(byte h, byte l);
Expand Down
Loading