Optimizations: remove multiple calls to the status() function. #3172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous commit broke the actual functionality. The code was confusing and worked until the previous commit. The changes make it logically and functionally correct.
Updated cursor.ino
…dapt using NetBeans as visual editor. Fixes #3140
…te for PreferencesData
… the editor has no such feature, CMD+J is disabled on mac. See #3098
Fix for FileUtils.recursiveDelete() when dealing with symbolic links
facchinm
added
Library: Ethernet
|
Merged as a9cdd44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At these places the status function is called multiple times without need.
Because there is a lot of Wire function inside I suggest reducing that and speeding up the functions.