Improvements to Stepper library #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speed resolution. Also optimized step routine a bit by removing extra call to get time.
|
|
||
|
|
||
| */ | ||
| For 4 wire configurations only, the motor can be driven with full-stepping (the default), |
There was a problem hiding this comment.
Is it necessary to have this comment in both the .h and .cpp file? It might be easier to maintain if i was exclusively in the .h (unless this is part of convention for the project).
- drive multiple steppers in unison - halt in the middle of a step sequence - callback in step loop - some optimizations for code size. code size is still ~2k larger than the previous version, however. Also, importing a simplified vector impl found on arduino forums.
| @@ -0,0 +1,73 @@ | |||
There was a problem hiding this comment.
Perhaps this would be better in a common location?
also refactored so to expose the meet of the step loop so people can roll their own if they like.
segfault. Also renaming the setDirection method and factoring out a method to force a step.
is actually in here.
cmaglie
added
feature request
tbowmo
pushed a commit
to tbowmo/Arduino
that referenced
this pull request
Jul 14, 2016
Fixing endless loop
|
Hi @smike , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I found the library very useful as a starting point, but thought it could use better speed resolution and some alternate drive types. Hopefully others will find it useful as well.
I've tested my changes on my Arduino Uno using a PX244-02A stepper in both unipolar and bipolar configurations.