Ethernet library: added ability to set/get hostname #5701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan-Perez
reviewed
Dec 13, 2016
| @@ -31,6 +32,7 @@ class EthernetClass { | |||
| IPAddress subnetMask(); | |||
| IPAddress gatewayIP(); | |||
| IPAddress dnsServerIP(); | |||
| char* hostname(); | |||
There was a problem hiding this comment.
Shouldn't it be const char* hostname() ?
…& Dhcp.getHostname()
|
Can we expect this to be merged anytime? |
|
any updates? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created overloaded Ethernet.begin() function that supports a host name parameter which is used by the DHCP request.
I've also added Ethernet.hostname() function which returns a hostname or an empty string if board was configured with static IP.
A simple example is located in the ./examples/DhcpHostname directory.