Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundled tools #5863

Merged
merged 4 commits into from
Feb 8, 2017
Merged

Update bundled tools #5863

merged 4 commits into from
Feb 8, 2017

Conversation

facchinm
Copy link
Member

@facchinm facchinm commented Jan 17, 2017

Solves arduino/arduinoOTA#2 and arduino/avrdude-build-script#4
Should also solve #5845, #5430 and #2989 . A test appx for Windows10 will be generated after the build for extended testing

@jmandion
Copy link

For me, compilation is now sucessful! But I've got this error when uploading the code

Arduino:1.8.2 (Windows XP), Tarjeta:"Arduino/Genuino Uno"

___REMOVE___/bin/avrdude -C___REMOVE___/etc/avrdude.conf -v -patmega328p -carduino -PCOM4 -b115200 -D -Uflash:w:C:\TEMP/Blink.ino.hex:i 
java.io.IOException: Cannot run program "___REMOVE___/bin/avrdude": CreateProcess error=2, El sistema no puede hallar el archivo especificado
	at java.lang.ProcessBuilder.start(ProcessBuilder.java:1048)
	at processing.app.helpers.ProcessUtils.exec(ProcessUtils.java:26)
	at cc.arduino.packages.Uploader.executeUploadCommand(Uploader.java:129)
	at cc.arduino.packages.uploaders.SerialUploader.uploadUsingPreferences(SerialUploader.java:207)
	at cc.arduino.UploaderUtils.upload(UploaderUtils.java:78)
	at processing.app.SketchController.upload(SketchController.java:709)
	at processing.app.SketchController.exportApplet(SketchController.java:682)
	at processing.app.Editor$DefaultExportHandler.run(Editor.java:2190)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.io.IOException: CreateProcess error=2, El sistema no puede hallar el archivo especificado
	at java.lang.ProcessImpl.create(Native Method)
	at java.lang.ProcessImpl.<init>(ProcessImpl.java:386)
	at java.lang.ProcessImpl.start(ProcessImpl.java:137)
	at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
	... 8 more

I'm going to test the last nighty build.

@jmandion
Copy link

The last nightly build worked perfectly! Thank you!

@cmaglie
Copy link
Member

cmaglie commented Jan 20, 2017

@jmandion what do you mean with "nightly build"?

please note that this patch, at this time is still not merged so it's not available in the Hourly build, but only in the build posted above.

To be clear if you want to test it you must use the file named arduino-PR-5863-BUILD-638.

@jmandion
Copy link

@cmaglie Interesting... Please, excuse my brevity in my previous comments. This evening, I've been testing an Arduino Uno with a laptop running Windows XP SP3.

First, I downloaded Arduino IDE 1.8.1 and my arduino was successfully detected. I tried to run the Blink example, but I got issue #2989
Next, I changed my build.path to C:\TEMP and moved my arduino installation to C:\Arduino to get paths without blank characters, but issue #2989 persisted.

Then, I reached this patch and downloaded arduino-PR-5863-BUILD-638. It solved issue #2989 and I could successfully link all the objects. However, when I tried to upload the executable to the arduino, I got the error I posted before: the "REMOVE" string in some paths.

Finally, I downloaded the hourly build (whose filename is arduino-nightly-windows.zip, this is the reason of my bad understanding about the timing of the testing builds). I've successfully compiled and uploaded the Blink example to my arduino.

@facchinm
Copy link
Member Author

The avrdude not found error (aka REMOVE) is "expected" since the avr core in this PR is not yet released and the tools definition gets overridden by the "official" json file. The important thing here is solving the compilation problem, however I'll add a temporary hack to make avrdude working again.
The fact that nightly compiles the Blink sketch without any problem is quite puzzling... Could you paste here the verbose output of the three compilations (1.8.1, nightly and PR-5863) ? Thanks a lot

@ArduinoBot
Copy link
Contributor

ArduinoBot commented Jan 23, 2017

✅ Build completed.

Please test this code using one of the following:

ATTENTION: this Windows appx is NOT the official release and is intended only for testing. You must uninstall the official build and enable "Sideload app" form Security to be able to test it
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5863-BUILD-638-windows-app.appx

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5863-BUILD-645-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5863-BUILD-645-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5863-BUILD-645-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5863-BUILD-645-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5863-BUILD-645-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@jmandion
Copy link

Sorry for the delay. These are the outputs of the three compilations. Some messages are in Spanish, but I think they are understandable.

Blink-Compilation-hourly.txt
Blink-Compilation-PR-5863-BUILD-638.txt
Blink-Compilation-v1.8.1.txt

@bmd1103
Copy link

bmd1103 commented Feb 6, 2017

Build 645 worked for me so far.

@per1234
Copy link
Collaborator

per1234 commented Feb 7, 2017

Arduino forum user stuart0 has been using test build 638 of this PR since 2017-01-18 on Windows XP without encountering #2989 once. Prior to using the test build they did experience #2989 multiple times. I will update if stuart0 reports any results to the contrary. I'm relaying the report because they don't have a GitHub account.

References:
original: https://forum.arduino.cc/index.php?topic=310950.msg3090378#msg3090378
latest update: http://forum.arduino.cc/index.php?topic=436394.msg3118041#msg3118041

@cmaglie cmaglie added Architecture: AVR Applies only to the AVR microcontrollers (Uno, etc.) Component: Toolchain The tools used for compilation and uploading to Arduino boards Type: Bug labels Feb 8, 2017
@facchinm facchinm added this to the Release 1.8.2 milestone Feb 8, 2017
@cmaglie cmaglie merged commit 7434443 into arduino:master Feb 8, 2017
@mastrolinux mastrolinux removed the in progress Work on this item is in progress label Feb 8, 2017
@cmaglie cmaglie deleted the new_tools branch February 8, 2017 16:50
@cmaglie
Copy link
Member

cmaglie commented Feb 8, 2017

Let's put the updated tools in the hourly, so a wider audience can test them.

@bmd1103
Copy link

bmd1103 commented Feb 8, 2017

Spoke too soon - I'm now getting
Linking everything together...
"C:\Program Files\Arduino_1.8\hardware\tools\avr/bin/avr-gcc" -Os -g -flto -fuse-linker-plugin -Wl,--gc-sections,--relax -mmcu=atmega2560 -o "C:\Temp1/Motors1.ino.elf" "C:\Temp1\sketch\Motor.cpp.o" "C:\Temp1\sketch\Motors1.ino.cpp.o" "C:\Temp1/core\core.a" "-LC:\Temp1" -lm
c:/program files/arduino_1.8/hardware/tools/avr/bin/../lib/gcc/avr/4.9.2/../../../../avr/bin/ld.exe: unrecognized option '-plugin'

c:/program files/arduino_1.8/hardware/tools/avr/bin/../lib/gcc/avr/4.9.2/../../../../avr/bin/ld.exe: use the --help option for usage information

collect2.exe: error: ld returned 1 exit status

So the collect2.exe error is coming up because of the unrecognised -plugin option.

@facchinm
Copy link
Member Author

facchinm commented Feb 9, 2017

@bmd1103 are you testing the nightly or the PR build? Both should have no problem with linker plugins, so I bet there is something wrong going on here.
update: I tested the nightly on XP with a Mega as target and it works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture: AVR Applies only to the AVR microcontrollers (Uno, etc.) Component: Toolchain The tools used for compilation and uploading to Arduino boards Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants