Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select (first) target board when port is selected and has known board #7120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sandeepmistry
Copy link
Contributor

Proposal to auto select the right target board type when a port is selected and we can identify the board via USB VID/PID.

This saves a menu click when switching between two connected boards. We could add a preference to enable this behaviour. cc/ @00alis

@per1234
Copy link
Collaborator

per1234 commented Jan 13, 2018

I think this is really great but it might get annoying always fighting it when using a custom bootloader that requires a different board selection from that indicated by the VID/PID. So it would be nice to have a way to disable it. Since custom bootloaders are a more advanced usage I think it would be fine to have this be a preferences.txt only setting.

@00alis
Copy link
Contributor

00alis commented Jan 16, 2018

Agreed with @per1234, let's keep it as a default setting and no need for a UI option, but we can have a way to disable it via preferences.txt

Nice work @sandeepmistry!

@facchinm
Copy link
Member

facchinm commented Jan 16, 2018

Could this work?

PS: I rebased it on beta-1.9, I think we'd better merge it there to get some feedback.

@sandeepmistry
Copy link
Contributor Author

@facchinm looks good! I'll give you write access to my fork so you can push it there ...

The setting is off by default.

Per-sketch board autoselection could work better because:
* Most 3rd party boards ship with generic USB to serial converters, making autoselection useless
* The port menu is not easily reachable as it is in Create
@sandeepmistry
Copy link
Contributor Author

@facchinm I've cherry-picked your commit for the preference.

@sandeepmistry
Copy link
Contributor Author

Note: we've made this opt-in as per the discussion with @facchinm, a 3rd party core could register the USB vid/pid of an existing board and might be selected as the board type when it shouldn't be.

@PaulStoffregen
Copy link
Contributor

I hope you'll avoid adding this to the Preferences dialog box.

That box is now quite large, and relative to most Arduino's history, growing rapidly. It already has tabs. If this GUI preference growth continues, eventually Arduino preferences will have the sort of UI complexity seen in IAR Workbench.

@facchinm facchinm added the IDE 1.9.x Beta Related to the Arduino IDE Beta Build label Apr 17, 2018
facchinm added a commit to facchinm/Arduino that referenced this pull request Mar 8, 2019
facchinm added a commit that referenced this pull request Mar 8, 2019
facchinm added a commit that referenced this pull request Mar 18, 2019
facchinm added a commit that referenced this pull request May 14, 2019
facchinm added a commit that referenced this pull request Jul 18, 2019
facchinm added a commit that referenced this pull request Jul 18, 2019
facchinm added a commit that referenced this pull request Jul 19, 2019
facchinm added a commit that referenced this pull request Jul 23, 2019
facchinm added a commit that referenced this pull request Sep 20, 2019
facchinm added a commit that referenced this pull request Sep 30, 2019
facchinm added a commit that referenced this pull request Oct 22, 2019
facchinm added a commit that referenced this pull request Feb 13, 2020
facchinm added a commit that referenced this pull request Mar 23, 2020
facchinm added a commit that referenced this pull request Apr 7, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ facchinm
❌ sandeepmistry
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDE 1.9.x Beta Related to the Arduino IDE Beta Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants