Skip to content

Correct messages regarding sketch/library folder name restrictions #7734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2018
+5 −4
Merged

Correct messages regarding sketch/library folder name restrictions #7734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/src/processing/app/SketchController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,8 +846,9 @@ private static String checkName(String origName) {

if (!newName.equals(origName)) {
String msg =
tr("The sketch name had to be modified. Sketch names can only consist\n" +
"of ASCII characters and numbers and be less than 64 characters long.");
tr("The sketch name had to be modified.\n" +
"Sketch names must start with a letter or number, followed by letters,\n" +
"numbers, dashes, dots and underscores. Maximum length is 63 characters.");
System.out.println(msg);
}
return newName;
Expand Down
4 changes: 2 additions & 2 deletions arduino-core/src/cc/arduino/contributions/libraries/LibrariesIndexer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ private void scanInstalledLibraries(UserLibraryFolder folderDesc) {
badLibNotified.add(subfolderName);

String mess = I18n.format(tr("The library \"{0}\" cannot be used.\n"
+ "Library names must contain only basic letters and numbers.\n"
+ "(ASCII only and no spaces, and it cannot start with a number)"),
+ "Library folder names must start with a letter or number, followed by letters,\n"
+ "numbers, dashes, dots and underscores. Maximum length is 63 characters."),
subfolderName);
BaseNoGui.showMessage(tr("Ignoring bad library name"), mess);
}
Expand Down