-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1, Allow tabs to adjust their size when there are too many tabs. 2, Highlight the words in finding and replacing them #8005
Conversation
I fixed the problem when there are too many tabs on the Editor header. When the remaining space is not enough, all tabs become as small as it is necesary to be to squash into the space.
Hi @soarcreator , thanks for your contribution! |
When finding and replacing the words, all these words are now highlighted yellow for the sake of visibility.
Hi, @facchinm Are you trying to change the tab size, depending on whether the tab is selected or not selected? It looks better to use my commit than these commits because mine has no bug so far. Additionally, those commits are against the naming rule of other codes. Mine is following the rule. |
New Feature: When finding and replacing the words, all these words are now highlighted yellow for the sake of visibility. |
@soarcreator it would be more appropriate to do that in a separate pull request since it's unrelated to the original proposal here. Create a separate feature branch in your repository for each pull request. Typically you would want to leave the |
@per1234 |
I will close this pull request to separate these two changes. |
The way I would do it is:
You could also use Note that this rewrites the history of your repository, which is not a good practice when other people might be relying on the history not changing and so generally should be avoided. However, in the case of a pull request, rewriting history is fine, and in fact preferred to the alternatives as a way to ensure a clean commit history if the PR is merged. It's probably a good idea to leave a note in the comment thread after rewriting a PR's commit history so that it's clear what happened. The alternative would be to simply push a new commit that reverts the unwanted commit. It is possible for the repository maintainers to do a "squash merge" of the pull request that will convert multiple commits of the PR into a single commit but this relies on the maintainer actually doing that. In my own PRs, I prefer to take proactive action to ensure the commit history generated by my PR is as I intended, rather than putting the responsibility on the maintainer to remember to do the right thing and figure out how GitHub's squash merge feature works. |
I fixed the problem when there are too many tabs on the Editor header. When the remaining space is not enough, all tabs become as small as it is necessary to be to squash into the space.