Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds to install.sh #9959

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds to install.sh #9959

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
718d22a
Adds to isntall.sh
shawayush Mar 28, 2020
aa8693e
changes as requested
shawayush Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions build/linux/dist/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,11 @@ simple_uninstall_f() {
# Update desktop file and mime databases (if possible)
updatedbs_f() {

if [ ! -f "${HOME}/root/.config/mimeapps.list" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • $[HOME}/root/.config/mimeapps.list folder doesn't look correct to me
  • chmod +x is wrong, this file is not supposed be executable

Finally, why you create an empty mimeapps.list? how is this supposed to fix #7846?
From what I read in #7846 there is xdg-mime that cannot create /root/.local/share/applications/mimeapps.list.new becuase the parent directory is nonexistent.

Are you able to reproduce the error reported in the issue #7846 ? If yes, have you tested this fix before submitting?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmaglie
yes, I was able to reproduce the error reported, and yes and I did the test before I submitted my PR, whatever PR I have given for this organization during the GSOC period, have been tested and reproduced the same, so that my PR may be merged efficiently without any problems. I am still working on one of the features in Arduino-cli. Though it might look wrong to you, I have tried my best to tackle that issue I encounter with it and came up with this reasonable solution, which apparently solves the issue.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ar
and after adding this patch to the code, this is what is written in that particular file, mimeapps.list

touch mimeapps.list
chmod +x mimeapps.list
fi

if [ -d "${HOME}/.local/share/applications" ]; then
if command -v update-desktop-database > /dev/null; then
update-desktop-database "${HOME}/.local/share/applications"
Expand Down