Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bool as return value for logical operations #147

Merged
merged 1 commit into from
May 25, 2021
Merged

Conversation

mcspr
Copy link
Contributor

@mcspr mcspr commented May 15, 2021

ref.
esp8266/Arduino#7939

Make sure comments are correct and make it clear to the user that these only return either true or false, and not a numeric value.

@CLAassistant
Copy link

CLAassistant commented May 15, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@facchinm What do you reckon? Any undesirable side-effects you can think of? Looks good to me.

@codecov-commenter
Copy link

Codecov Report

Merging #147 (a010db7) into master (e2d2f20) will not change coverage.
The diff coverage is 95.55%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files          13       13           
  Lines         835      835           
=======================================
  Hits          802      802           
  Misses         33       33           
Impacted Files Coverage Δ
api/String.cpp 97.69% <95.12%> (ø)
api/String.h 90.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d2f20...a010db7. Read the comment docs.

@per1234
Copy link
Collaborator

per1234 commented May 25, 2021

It was rolled out to all ESP8266 users in that platform's 3.0.0 release 9 days ago and I haven't seen any reports of problems from them. But I'm also not super tuned in to the ESP8266 community.

@facchinm
Copy link
Member

@aentinger I can't see any undesirable side effect since the usual promotion/demotion automatic rules apply, I'm ok for merging it 😉

@aentinger
Copy link
Contributor

Good to go then. Can't think of any undesirable side-effects myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants