Skip to content

CurieBLE: Add support for "some" 16-bit + 128-bit UUID's and shortened name #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sandeepmistry
Copy link
Contributor

These changes resolve #371 and #372 for me.

@SidLeung
Copy link
Contributor

SidLeung commented Jan 6, 2017

This issue is logged as Jira 792. It is under internal review, testing. Upon completion, will be merged to master and in the nightly JSON build. Will update here when the JSON has this change.

@sandeepmistry
Copy link
Contributor Author

The data structure for "some" and "all" EIR types are the same, it's more semantics. "All" means all the services the peripheral provides are advertised, "some" means only some of the services are advertised, when the connected to the peripheral can have more services than advertised.

@SidLeung
Copy link
Contributor

SidLeung commented Mar 3, 2017

PR #450 addresses this request. Will be in the next release.

@SidLeung SidLeung assigned sandeepmistry and unassigned SidLeung Mar 3, 2017
@kitsunami kitsunami added this to the Deneb milestone Mar 9, 2017
@sandeepmistry
Copy link
Contributor Author

Closing this, as this PR was replicated in #450 which has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CurieBLE: cannot discover advertised 16-bit service of SensorTag
3 participants