shared memory structure changes for CODK-M #394
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eriknyquist please review |
|
Almost there. give a little detail in the commit message please-- subject is good now, but need some more details below. Like, what exactly are the changes (very briefly), and most importantly why are these changes needed? |
-added struct for ipm using shared memory -added cdc-acm buffer space on shared memory which is used by the new firmware
bigdinotech
force-pushed
the
codkm-platform
branch
from
4e428e3 to
25fc6ed
Compare
|
@eriknyquist I added the commit message |
|
I'm still confused. I don't understand why the IPM struct is needed in shared memory? |
|
IPM struct is part of CODK-M firmware |
eriknyquist
approved these changes
Jan 17, 2017
|
Ping! Assigning to @bigdinotech for merging, if he's ready for it |
|
@eriknyquist @calvinatintel this PR has already been merged by sysmaker |
|
OK, close it then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.