CurieBLE: Set characteristic value internally if it not associated with a service yet #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sandeepmistry , please consider this conversation, |
eriknyquist
approved these changes
Mar 20, 2017
|
See discussion in #366 (comment) for comment above |
|
@russmcinnis , @noelpaz , please proceed with system testing. |
|
we have system tested and it passes. No unit test yet. |
|
I used the sketch from #366 that connects and used nRF connect to read the value that has not been set. It shows up as Value: (0x)00 |
russmcinnis
approved these changes
Mar 21, 2017
There was a problem hiding this comment.
I used the sketch from #366 that connects and used nRF connect to read the value that has not been set. It shows up as Value: (0x)00
I believe this is the expected behavior.
|
Passed system test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #366.
As outlined in the sketch provided in #366 (comment).
The initial value of 0x00 that was set by the type characteristic was dropped because it has not been associated with a service yet via
addCharacteristic(...). This change stores the value internally like theBLECharacteristic(const char* uuid, unsigned char properties, const char* value)constructor path.