Drastically speedup client.read() operation #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the data being consumed by the reader thread is going to be read somewhere via read() APIs (that are known to be fair and call yield()), we can avoid the delay() when the buffer needs to be flushed by setting the reader thread priority to something lower than the main thread. To be tested on some real world applications (by now, tested with Ethernet/WiFi Client/Server "basic" examples)
|
Memory usage change @ 9619ec8
Click for full report table
Click for full report CSV |
giulcioffi
approved these changes
Apr 4, 2022
Some libraries don't call close() and expect the device will do it on its own when the server closes the connection. To fix this, the best thing to do would be either to use connectionKeepAlive() or to simply close() the client before conneting again. For backwards compatibility, let's start from scratch every time connect() is colled twice.
This was referenced Apr 5, 2022
Closed
|
Memory usage change @ d30df6d
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the data being consumed by the reader thread is going to be read somewhere via read() APIs (that are known to be fair and call yield()), we can avoid the delay() when the buffer needs to be flushed by setting the reader thread priority to something lower than the main thread.
To be tested on some real world applications (by now, tested with Ethernet/WiFi Client/Server "basic" examples)
Fixes #438
@manchoz