-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AE-74] Revamp Battery API for Nicla Sense ME #680
Conversation
LATM – Looks Awesome To Me |
LATM! 😃 Nicla - PC WebBLE communication works as described. 😔 Reported battery voltage differs between WebBLE interface (3.86V) and scope
This difference could be due to internal resistance of the ground plane. |
e398b6b
to
b16d5ea
Compare
@aliphys Found another bug and fixed it. Basically the battery reading was not done correctly so it would only ever use what is measured when you plug it in. |
7e8b72e
to
d47a6db
Compare
4de1f9d
to
34b9666
Compare
@facchinm
That aside, I think I'm done here. Waiting for @aliphys ' green light 🟢 |
7018622
to
d399ee3
Compare
9c88907
to
5fff648
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the detailed PR and comments: we should try to strive for this level of quality.
Battery voltage updates correctly 👍
...la_System/examples/NiclaSenseME_BatteryChargingSimple/NiclaSenseME_BatteryChargingSimple.ino
Outdated
Show resolved
Hide resolved
...la_System/examples/NiclaSenseME_BatteryChargingSimple/NiclaSenseME_BatteryChargingSimple.ino
Outdated
Show resolved
Hide resolved
libraries/Nicla_System/examples/NiclaSenseME_BatteryStatus/NiclaSenseME_BatteryStatus.ino
Show resolved
Hide resolved
...la_System/examples/NiclaSenseME_BatteryChargingSimple/NiclaSenseME_BatteryChargingSimple.ino
Show resolved
Hide resolved
Co-authored-by: Ali Jahangiri <75624145+aliphys@users.noreply.github.com>
Change log
🐛 Fixed Bugs
🚀 Enhancements
🆕 New Features