Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiFiS3 - macAddress() return normal bytes ordering #183

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

JAndrassy
Copy link
Contributor

@JAndrassy JAndrassy commented Nov 10, 2023

The firmware of the first WiFi library returned the MAC address in reversed ordering. It was fixed in examples and not in the macAddress method. Since then every WiFi library by Arduino reverses the MAC address in macAddress to reversed ordering and some reverse BSSID too. Then the examples print it reversed.

Why continue with this in new libraries?

here BSSID was not reversed so examples printed it reversed.

overview of WiFi/Ethernet getters and setters:
https://github.com/JAndrassy/Arduino-Networking-API/blob/main/ArduinoNetAPILibs.md#network-interface-getters-and-setters

BSSID was not reversed so examples printed it reversed
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Nov 10, 2023
@arduino arduino deleted a comment from github-actions bot Dec 5, 2023
@aentinger aentinger merged commit 05feca5 into arduino:main Dec 14, 2023
7 checks passed
@JAndrassy JAndrassy deleted the wifis3_mac_bytes_ordering branch December 14, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants