Use correct datatype for return value of FspTimer::get_available_timer() #288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #282 :
I missed in my previous PR that the return value from
FspTimer::get_available_timer()
is actually anint8
, but in Arduino_LED_Matrix.h is stored asuint8
.Therefore the following if (added in #282) cannot work as intended:
ArduinoCore-renesas/libraries/Arduino_LED_Matrix/src/Arduino_LED_Matrix.h
Lines 175 to 178 in 2c8dd57
This PR is to use the correct datatype. Ideally it should have been included in my previous PR.