Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adc_set_resolution bug #129

Open
avsteele opened this issue Oct 15, 2021 · 0 comments
Open

adc_set_resolution bug #129

avsteele opened this issue Oct 15, 2021 · 0 comments

Comments

@avsteele
Copy link

in adc.c:

void adc_set_resolution(Adc *p_adc,const enum adc_resolution_t resolution)
{
	p_adc->ADC_MR |= (resolution << 4) & ADC_MR_LOWRES;
}

is incorrect. The RHS always evaluates to 0 since the valid values of enum adc_resolution_t as seen in adc.h are 0 (ADC_12_BITS), or 16 (ADC_10_BITS)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@avsteele