Skip to content

Adding a NUL byte corrupts String administration #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SodaqMoja opened this issue Nov 19, 2017 · 1 comment
Closed

Adding a NUL byte corrupts String administration #279

SodaqMoja opened this issue Nov 19, 2017 · 1 comment
Labels
bug Print and Stream class

Comments

@SodaqMoja
Copy link

ArduinoCore-samd/cores/arduino/WString.cpp

Line 285 in e6df241

buf[0] = c;

When adding '\0' to a String, the length will be incremented, but the NUL character is not written to the underlying buffer. The reason is that in concat() a strcpy is used which does nothing in this case. But the length is still incremented.
@dav1901 dav1901 mentioned this issue Nov 7, 2018
Closed
@shawayush shawayush mentioned this issue Apr 7, 2020
Closed
@aentinger
Copy link
Contributor

\0 entries are currently not supported, however this may change if and when arduino/ArduinoCore-API#97 is merged. Since those changes will be propagated via ArduinoCore-API integration into ArduinoCore-samd this issue can in fact be closed.

boseji pushed a commit to go-ut/combined-ArduinoCore-samd that referenced this issue Feb 3, 2021
@PaintYourDragon
Merge pull request arduino#279 from RudolphRiedel/master
12e0a79 
Added a isBusy() method to SPI calls to allow non-blocking polling of…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Print and Stream class
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aentinger @SodaqMoja @facchinm