Make attachInterrupt work as documented #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
…[pin].ulExtInt to map pin inside attachInterrupt/detachInterrupt This brings things inline with the atachInterrupt documentation for usage: attachInterrupt(digitalPinToInterrupt(pin), ISR, mode);
…nce it 1.6.5 or higher
sandeepmistry
force-pushed
the
attachInterrupt-match-docs
branch
from
7c2c265 to
1c8071a
Compare
|
@cmaglie I've rebased this, bumped compliance level to 1.6.6 (since 1.6.5 is released) and also applied to the MKR1000 variant. Please review. |
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
boseji
pushed a commit
to go-ut/combined-ArduinoCore-samd
that referenced
this pull request
May 30, 2020
Tinyusb branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the
attachInterruptdocs, the recommended usage is:This currently does not work with the SAMD core because
digitalPinToInterruptis used insideattachInterrupt, so the pin number must be passed in.This patch addresses this by changing
digitalPinToInterruptto return the argument passed in.attachInterruptanddetachInterruptwill useg_APinDescription[pin].ulExtInt;to map the pin to interrupt number directly.It also moves
digitalPinToInterruptinsideArduino.h(ifARDUINO_SAMD_VARIANT_COMPLIANCEis >= 1.6.5). Existing behaviour will be used in variants with older compliance levels.I've also added a new change log for variant compliance changes.