Skip to content

[DO NOT MERGE] Update to CMSIS 5.5.0 #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sandeepmistry
Copy link
Contributor

Depends on arduino/ArduinoModule-CMSIS#3.

@cmaglie @facchinm what do you think about update CMSIS from 4.5 to 5.5?

@ArduinoBot
Copy link

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/samd/package_samd-b201_index.json

ℹ️ To test this build:

  1. Open the Preferences of the Arduino IDE.
  2. Add the Build URL above in the Additional Boards Manager URLs field, and click OK.
  3. Open the Boards Manager (menu Tools->Board->Board Manager...)
  4. Install Arduino SAMD core - Pull Request [DO NOT MERGE] Update to CMSIS 5.5.0 #392
  5. Select one of the boards under SAMD Pull Request [DO NOT MERGE] Update to CMSIS 5.5.0 #392 in Tools->Board menu
  6. Compile/Upload as usual

@@ -64,8 +64,8 @@ compiler.S.extra_flags=
compiler.ar.extra_flags=
compiler.elf2hex.extra_flags=

compiler.arm.cmsis.c.flags="-I{runtime.tools.CMSIS-4.5.0.path}/CMSIS/Include/" "-I{runtime.tools.CMSIS-Atmel-1.1.0.path}/CMSIS/Device/ATMEL/"
compiler.arm.cmsis.ldflags="-L{runtime.tools.CMSIS-4.5.0.path}/CMSIS/Lib/GCC/" -larm_cortexM0l_math
compiler.arm.cmsis.c.flags="-I{runtime.tools.CMSIS-5.5.0.path}/CMSIS/Core/Include/" "-I{runtime.tools.CMSIS-5.5.0.path}/CMSIS/DSP/Include/" "-I{runtime.tools.CMSIS-5.5.0.path}/CMSIS/NN/Include/" "-I{runtime.tools.CMSIS-Atmel-1.1.0.path}/CMSIS/Device/ATMEL/"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting linker errors when trying to use NN functions, they are not pre-compiled like the DSP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeepmistry do you think they are not precompiled because they use some features not commonly deployed across a microarchitecture family? In that case the only thing I can think about is turning them into Arduino libraries (which is bad, but not terrible, since CMSIS changes are in sync with the core)

@ArduinoBot
Copy link

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/samd/package_samd-b205_index.json

ℹ️ To test this build:

  1. Open the Preferences of the Arduino IDE.
  2. Add the Build URL above in the Additional Boards Manager URLs field, and click OK.
  3. Open the Boards Manager (menu Tools->Board->Board Manager...)
  4. Install Arduino SAMD core - Pull Request [DO NOT MERGE] Update to CMSIS 5.5.0 #392
  5. Select one of the boards under SAMD Pull Request [DO NOT MERGE] Update to CMSIS 5.5.0 #392 in Tools->Board menu
  6. Compile/Upload as usual

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants