-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use RESET_N pin #550
Conversation
Data sheet discourages use of SARA modem reset pin, use may lead to irrecoverable state of modem
@aentinger Here is the change we discussed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thank you for your contribution, just please perform a rebase first.
pinMode(SARA_RESETN, OUTPUT); | ||
digitalWrite(SARA_RESETN, HIGH); | ||
digitalWrite(SARA_RESETN, LOW); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @janakelarsson 👋 This line is already in ArduinoCore-samd:master:HEAD - please rebase your commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aentinger Better now (I don't have a local copy of the git archive for that small change so I mistakenly thought the green light meant the PR was OK)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or do I need to squash the commits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good now, I'll squash them myself.
Update to arduino master
Update from master
Change comment: Data sheet discourages use of SARA modem reset pin, use may lead to irrecoverable state of modem