Re-add deprecated-avr-comp to include folders #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ 86cf01b
Click for full report table
|
Herschdorfer
approved these changes
Dec 23, 2020
per1234
suggested changes
Dec 23, 2020
| @@ -247,6 +247,7 @@ jobs: | |||
| - name: LoRa | |||
| - name: MKRWAN | |||
| - name: WiFiNINA | |||
| - name: AceTime | |||
There was a problem hiding this comment.
This causes the AceTime library to be installed via Library Manager, and nothing more.
If you want to also compile the AceTime library's examples, you should add their path to env.UNIVERSAL_SKETCH_PATHS (I'm guessing there is nothing board-specific about those examples):
- ~/Arduino/libraries/AceTime/examples
I'm happy to submit a PR against your PR branch to add this if you prefer.
There was a problem hiding this comment.
Yes, thanks! I completely misinterpreted the meaning of that entry 😄
This change causes the "Compile Examples" CI workflow to compile AceTime library's "HelloDateTime" example sketch for every board in the job matrix.
Configure CI workflow to compile AceTime library example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows old includes like
to be functional again.