fix: address warning #610
Closed
fix: address warning #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves issues #604. |
|
I'm scratching my head here... What is the expected behavior that is being failed by a test? The warning needs to be addressed, because it appears this function can return whatever happens to be on the end of the stack. Perhaps this needs to be completely refactored by the original author to have a more clear and deterministic outcome. |
|
After reviewing the detailed build logs, it appears there is an unrelated This issue has already be raised as #606. |
|
Replaced by #618, which is a bit cleaner and more commented. Thanks anyway, sorry for the late response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provide return value for "unused" path