fix Serial.flush() blocks forever #597 #652
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
causes issues (lockups) when the TX DATA register is empty on start
and a flush is issued. Simply looking at the DRE prior to
waiting for TXC is insufficient because the data register
may well be empty but the shift register could still contain
data, in this case SERCOM::flushUART() would return before TXC
has been raised thus before flushing is complete.
SERCOM::flushUART() to wait for the TXC flag. This flag is
set when any data is written to the data register via
SERCOM::writeDataUART(). It is cleared when a flush is done.
Fixes #597