Skip to content

Added legacy pin coverager for nano boards #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

mjs513
Copy link

@mjs513 mjs513 commented Jan 30, 2025

While playing with SDfat kept getting an error about ss pin not defined. Then @KurtE reminded that on the teensy they are defined in the core. Then remembered say that for the giga. When I looked for the nano boards (variant.h) they were not covered. This PR adds:

// TODO: correctly handle these legacy defines
#define MOSI    0
#define MISO    0
#define SCK     0
#define SS      0
#define SDA     0
#define SCL     0

to the nano variant.h files (ble, sense and iot).

recompiled core and retested and the sdfat compile error disappeared.

@mjs513
Copy link
Author

mjs513 commented Jan 30, 2025

after testing sdfat had to actually specify pins for SPI which we didn't have to do for GIGA spi.

@facchinm - @KurtE: Not sure if we should specify pins for SDA/SCL as well since NANO is different that giga it seems

@facchinm facchinm merged commit eabeb63 into arduino:arduino Mar 5, 2025
2 of 4 checks passed
@mjs513 mjs513 deleted the Legacy-SPI/I2C-pins---variants.h branch March 31, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants