Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How does openocd search and select the developed cmsis-dap download program #6

Closed
ouki-wang opened this issue May 20, 2018 · 1 comment
Closed

How does openocd search and select the developed cmsis-dap download program #6

ouki-wang opened this issue May 20, 2018 · 1 comment
Labels
question

Comments

@ouki-wang
Copy link

Several cmsis-dap devices are linked on my computer. How does openocd search and select the cmsis-dap download program?
@facchinm
Copy link
Member

In fact, openocd doesn't. It depends on the commandline you give it; the default one we use doesn't specify any serial number, so if you connect two programmers with the same vid and pid it fails. You can specify the serialnumber of the programmer you want to target with cmsis_dap_serial [serial] (see http://openocd.org/doc/html/Debug-Adapter-Configuration.html)

facchinm pushed a commit to facchinm/OpenOCD that referenced this issue Jun 8, 2018
@tom-van
helper/types: cast to uint32_t,uint16_t to avoid UB by shifting int t…
d4ef54c 
…oo far

Without this, we have some types promoted to `int` when they need to be
`unsigned int`.

Here's some ubsan output hitting this:

Unfortunately, what happens is that things get promoted to `int`, but
need to be `unsigned int`. Here's the ubsan output:

src/helper/types.h:126:65: runtime error: left shift of 255 by 24 places cannot be represented in type 'int'
    #0 0x55978a612060 in le_to_h_u32 src/helper/types.h:126
    arduino#1 0x55978a61ff9e in stlink_usb_read_reg src/jtag/drivers/stlink_usb.c:1539
    arduino#2 0x55978a8cfd45 in adapter_load_core_reg_u32 src/target/hla_target.c:67
    arduino#3 0x55978a9f48e3 in armv7m_read_core_reg src/target/armv7m.c:236
    arduino#4 0x55978a8d24fc in adapter_load_context src/target/hla_target.c:372
    arduino#5 0x55978a8d261b in adapter_debug_entry src/target/hla_target.c:396
    arduino#6 0x55978a8d3123 in adapter_poll src/target/hla_target.c:457
    arduino#7 0x55978a528357 in target_poll src/target/target.c:535
    arduino#8 0x55978a539fd4 in target_wait_state src/target/target.c:2914
    arduino#9 0x55978a556e20 in jim_target_wait_state src/target/target.c:5256
    arduino#10 0x55978a5cca62 in command_unknown src/helper/command.c:1030
    arduino#11 0x55978aaed894 in JimInvokeCommand /home/cody/d/openocd-code/jimtcl/jim.c:10364

Change-Id: I24f6abfd26b6980100657397d69c84f2b80a005a
Signed-off-by: Cody P Schafer <openocd@codyps.com>
Reviewed-on: http://openocd.zylin.com/4455
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Tested-by: jenkins
Reviewed-by: Christopher Head <chead@zaber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@facchinm @ouki-wang