Skip to content

Examples cleanup #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 25, 2024
Merged

Examples cleanup #37

merged 14 commits into from
Nov 25, 2024

Conversation

eigen-value
Copy link
Contributor

Revamped all the examples:

  • removed dependency from sys module and sys.exit() calls
  • rationalization of the demo examples
  • introduces some examples leveraging the arduino runtime

@eigen-value eigen-value requested a review from gbr1 November 20, 2024 17:05
@eigen-value eigen-value changed the base branch from main to dev November 20, 2024 17:05
Copy link
Member

@gbr1 gbr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • demo.py is wrong -> it seems to be touch_move.py
  • on mpy 1.22.2 main not import demo (I don't know why)
  • arduino_runtime examples must contain cleanup with alvik.stop() -> start(setup,loop, cleanup)

@eigen-value
Copy link
Contributor Author

@gbr1
demo, touch_move and runtime examples have been amended.

Are you sure about the MP 1.22.2 issue? It seems alright to me... maybe a failed reimport?

@gbr1 gbr1 self-requested a review November 25, 2024 10:45
Copy link
Member

@gbr1 gbr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is smooth :D

@gbr1 gbr1 marked this pull request as ready for review November 25, 2024 10:46
@eigen-value eigen-value merged commit ec88c74 into dev Nov 25, 2024
1 check passed
@gbr1 gbr1 deleted the examples_cleanup branch November 25, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants