Skip to content

Don't wipe everything is only sketch path changed #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2016

Conversation

facchinm
Copy link
Member

If the environment variables are untouched but the sketch is saved automatically by the Java IDE (to another folder) the infamous "Build options changed" is triggered.
This commits adds a second check after removing the sketch location from the env variables, and skips the wipeout if the partial environments are equals

Should solve arduino/Arduino#4713
@matthijskooijman @cmaglie @sandeepmistry @mbanzi

Signed-off-by: Martino Facchin <m.facchin@arduino.cc>
@facchinm facchinm force-pushed the build_options_changed branch from 49a67a6 to 4b6614e Compare March 22, 2016 14:10
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-129.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

@matthijskooijman
Copy link
Collaborator

Wouldn't this cause cache to be re-used even when you load a different sketch? Or are there other variables that will change then as well?

In any case, I think the proper fix for this problem is to let arduino-builder know both the original sketch location as well as the temporary saved copy, which allows it to be smarter about other things (like debugging symbols) too. See #86 for a writeup on how I think this should look.

@facchinm
Copy link
Member Author

Changing the IDE active window or changing the target board triggers a wipe, so there shouldn't be much issues. Anyway, I'm merging this to give it some staging time in nightly and eventually, if there is any drawback, we'll take care of reverting

@facchinm facchinm merged commit 47f3fc4 into arduino:master Mar 25, 2016
@cmaglie cmaglie deleted the build_options_changed branch January 11, 2018 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants