-
-
Notifications
You must be signed in to change notification settings - Fork 114
add #line directive to additional source files #1 #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
improvement for #323
I realized I made a mistake and forgot the important "QuoteCppString" |
FYI, you could have (force-)pushed to the existing branch to update this PR rather than create a new one (but no harm done of course, just for future reference). |
Oh sorry, did not know that was possible. Even though experienced with git,
I am new to GitHub. Thank you for telling me!
BTW, how long could it take for this change to get to the main branch and
main build?
|
Arduino: Most changes need months(best case) to years - 99% of suggestions are accepted never. |
Thanks for your honest answer, though it was not very encouraging... |
Yes, I'm not sure why they use Github. It's so miselading for others as they think they can contribute and so they spend their free time for nothing... |
In practice, there's a lot more contributions than there is manpower to review, polish and eventually merge them, unfortunately. This seems like a fairly small change, so that makes things easier. I'm not the one that decides whether to merge something, but I can perhaps help things along by providing a review :-) |
Thank you for trying to help! |
I double checked the contents of the additional files list, it can contain files with these extensions: |
Please reply in the other PR, since here it won't be seen :-) |
Moved it there. Added a little bit more. |
improvement for #323