Skip to content

add #line directive to additional source files #1 #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add #line directive to additional source files #1 #324

wants to merge 1 commit into from

Conversation

slady
Copy link

@slady slady commented Jun 20, 2019

improvement for #323

@slady slady closed this Jun 20, 2019
@slady
Copy link
Author

slady commented Jun 20, 2019

I realized I made a mistake and forgot the important "QuoteCppString"

@matthijskooijman
Copy link
Collaborator

FYI, you could have (force-)pushed to the existing branch to update this PR rather than create a new one (but no harm done of course, just for future reference).

@slady
Copy link
Author

slady commented Jun 20, 2019 via email

@FrankBoesing
Copy link

Arduino: Most changes need months(best case) to years - 99% of suggestions are accepted never.
For the builder it seems to by slightly better..

@slady
Copy link
Author

slady commented Jun 20, 2019

Thanks for your honest answer, though it was not very encouraging...

@FrankBoesing
Copy link

FrankBoesing commented Jun 20, 2019

Yes, I'm not sure why they use Github. It's so miselading for others as they think they can contribute and so they spend their free time for nothing...

@matthijskooijman
Copy link
Collaborator

In practice, there's a lot more contributions than there is manpower to review, polish and eventually merge them, unfortunately. This seems like a fairly small change, so that makes things easier. I'm not the one that decides whether to merge something, but I can perhaps help things along by providing a review :-)

@slady
Copy link
Author

slady commented Jun 20, 2019

Thank you for trying to help!

@slady
Copy link
Author

slady commented Jun 20, 2019

I double checked the contents of the additional files list, it can contain files with these extensions:
.h .c .hpp .hh .cpp .s
Hope all of them can start with the #line directive.

@matthijskooijman
Copy link
Collaborator

Please reply in the other PR, since here it won't be seen :-)

@slady
Copy link
Author

slady commented Jun 20, 2019

Moved it there. Added a little bit more.
Hope somebody reads it in this century.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants