Skip to content

Fix buildpath regression #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2019
Merged

Fix buildpath regression #337

merged 3 commits into from
Sep 23, 2019

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 20, 2019

WIP: do not merge before arduino/arduino-cli#418

There were actually two bugs:

  • the command line parsing check, to see if the build-path parameter has been passed, should be done against the empty string ("") and not against nil
  • the old ctx.ToolsDirs parameter has been replaced by ctx.BuiltInToolsDirs but this has not been reflected in the builder main.go

Not related with this PR but required to compile:

  • the function Unquote has been moved from arduino-cli to this repository

Should fix #336

@cmaglie
Fix build-path parameter parsing regression
5831227 
The flags package always set the string flags default to the empty
string. We should test for that and not nil.
@cmaglie
Moved legacy function unquote from arduino-cli here
8ca011a
@cmaglie
Using BuiltInToolsDirs instead of ToolsDirs
0f18c2d
@arduino arduino deleted a comment from ArduinoBot Sep 20, 2019
@arduino arduino deleted a comment from ArduinoBot Sep 20, 2019
@arduino arduino deleted a comment from ArduinoBot Sep 20, 2019
@arduino arduino deleted a comment from ArduinoBot Sep 20, 2019
@arduino arduino deleted a comment from ArduinoBot Sep 20, 2019
@cmaglie
Copy link
Member Author

cmaglie commented Sep 20, 2019

@ArduinoBot build this please

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-337.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

@cmaglie cmaglie mentioned this pull request Sep 20, 2019
Closed
@cmaglie cmaglie merged commit 1b96a97 into arduino:master Sep 23, 2019
@cmaglie cmaglie deleted the fix-buildpath-regression branch September 23, 2019 08:32
@obra obra mentioned this pull request Sep 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to use arduino-builder released with 1.8.10
2 participants
@cmaglie @ArduinoBot