-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newer library is not listed as available #1041
Comments
Upgrading the library works though:
Please note that I supplied the spaced library name to |
I can confirm this is a problem on Windows 10 on cli version 0.14.0. I also suspect spaces in the "real name" of the library to play a role in this. But running |
@paulsiersma |
@ubidefeo Thank for your comment, but the |
@paulsiersma @alranel mentions he used the spaced name which is correct, search happens against the I haven't been able to reproduce this issue, but maybe it's Windows only |
I can easily reproduce this issue on Raspberry OS (Debian Buster):
Arduino-cli shows only for WiFiNINA that a new version is available.
System:
Might be related to #932. |
Also, I cannot upgrade the library by setting its name as a parameter in the lib upgrade command:
All three commands do not have any effect. |
A work around for me is to uninstall the library and the reinstall it. arduino-cli lib uninstall "Adafruit SH110X"
arduino-cli lib install "Adafruit SH110X" Ubuntu 20.04.4 |
I was running into this on multiple platforms (MacOS, debian/Raspberry Pi OS) so I decided to take a look. The issue is definitely in the resolution of existing installed package names versus the indexed package names. If a package contains spaces in its
then show the list:
Trying to upgrade RTCZero works fine:
Doing the same with the Adafruit BMP280 Library with any permutation fails to upgrade. Digging around in the code a little, I think this is down to the implementation of func (idx *Index) FindIndexedLibrary(lib *libraries.Library) *Library {
return idx.Libraries[lib.Name]
} That isn't going to work, because the installed lib name will be something like "Adafruit_BMP280_Library" and the index name will be "Adafruit BMP380 Library". I tried a trivial fix: func (idx *Index) FindIndexedLibrary(lib *libraries.Library) *Library {
clean := strings.ReplaceAll(lib.Name, "_", " ")
return idx.Libraries[clean]
} Which ends up looking like this after a build:
The @ubidefeo if this looks like a reasonable fix, I'll submit a PR. |
@stonehippo |
Bug Report
Current behavior
The installed version of
Adafruit_ST7735_and_ST7789_Library
is 1.5.18 and no newer version is listed under "Available".Expected behavior
As of now, the library index contains the version 1.6.0 of
Adafruit ST7735 and ST7789 Library
, so I would expect it to be listed.This is correctly reflected in the IDE:
Environment
arduino-cli version
): 0.13.0 Commit: 693a045The text was updated successfully, but these errors were encountered: