Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] preprocessor define in config (or on command line directly) #1070

Closed
i-make-robots opened this issue Nov 13, 2020 · 4 comments
Assignees
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@i-make-robots
Copy link

i-make-robots commented Nov 13, 2020

Thank you for your great work on arduino-cli. I really appreciate all your time & energy.

I would like to feed arduino-cli a matrix of AVR types and machine styles to test them all, automatically, in a Github Action.
I have https://github.com/MarginallyClever/Makelangelo-firmware/edit/master/.github/workflows/main.yml
Many AVRs, many kinematic models run by one firmware.
kinematic models are decided with a preprocessor directive. for instance,

#define MACHINE_STYLE = POLARGRAPH

Please! In a perfect world I would like to call

arduino-cli compile --fqbn arduino:avr:mega ./Makelangelo-firmware.ino --define MACHINE_STYLE = POLARGRAPH

If this is already possible I do apologize, I was unable to find the documentation.

@obra
Copy link
Contributor

obra commented Nov 13, 2020

#846 and #1044 are at least related.

extra_flags and --build-property may give you the rope you need.

@per1234
Copy link
Contributor

per1234 commented Nov 13, 2020

Closing as duplicate of #159

@per1234 per1234 closed this as completed Nov 13, 2020
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Nov 13, 2020
@i-make-robots
Copy link
Author

Oh awesome. I didn't find the documentation for this (fairly new) feature. Sorry to bother. Stay Excellent!

@rsora rsora reopened this May 11, 2021
@i-make-robots
Copy link
Author

i-make-robots commented May 11, 2021

I have moved to platformio where it would be -DROBOT_POLARGRAPH -DBOARD_RUMBA.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 11, 2023
@per1234 per1234 self-assigned this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

5 participants